Skip to content

Conversation

@alexey-tikhonov
Copy link
Member

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to improve compatibility with FreeBSD, likely to fix CI failures. The changes include updating shebangs in shell scripts to #!/usr/bin/env bash for better portability and adjusting a test assertion to handle platform differences in getsockopt return values. However, there is a debugging change in test_pam_srv.c that hardcodes a high debug level. This change appears to be temporary and should be reverted before merging.


/* Set debug level to invalid value so we can decide if -d 0 was used. */
debug_level = SSSDBG_INVALID;
debug_level = 9;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change hardcodes the debug level to 9, which is a very high verbosity level. This appears to be a temporary change for debugging purposes, as suggested by the pull request title. Hardcoding debug levels, especially high ones, in test files is not recommended for permanent inclusion as it can lead to excessively verbose logs, potentially masking other issues. Furthermore, the preceding comment on line 5166 is now inaccurate. This line should be reverted to its original state.

    debug_level = SSSDBG_INVALID;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants