Skip to content

[autobackport: sssd-2-12] removing netgroup intg test#8358

Merged
spoore1 merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8356-to-sssd-2-12
Jan 15, 2026
Merged

[autobackport: sssd-2-12] removing netgroup intg test#8358
spoore1 merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8356-to-sssd-2-12

Conversation

@sssd-bot
Copy link
Contributor

This is an automatic backport of PR#8356 removing netgroup intg test to branch sssd-2-12, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8356-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8356-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8356-to-sssd-2-12 --force

Original commits
ab7a7f4 - removing netgroup intg test

Backported commits

  • b127464 - removing netgroup intg test

Original Pull Request Body

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the netgroup integration test (test_netgroup.py). The change is straightforward, but it appears to be incomplete, leaving behind orphaned files and build definitions. My review includes a comment pointing out these leftovers that should also be removed to ensure a clean codebase.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit ab7a7f4)
@sssd-bot
Copy link
Contributor Author

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8356-to-sssd-2-12 branch from b127464 to 3b0bd7f Compare January 15, 2026 19:01
@spoore1 spoore1 merged commit 7adbf2e into SSSD:sssd-2-12 Jan 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants