Translations update from Fedora Weblate#8362
Conversation
Added translation using Weblate (Turkish) Added translation using Weblate (Polish) Added translation using Weblate (Norwegian Bokmål) Added translation using Weblate (Korean) Added translation using Weblate (Georgian) Added translation using Weblate (Italian) Added translation using Weblate (Indonesian) Added translation using Weblate (Hungarian) Added translation using Weblate (Bulgarian) Added translation using Weblate (Latvian) Added translation using Weblate (Korean) Added translation using Weblate (Georgian) Added translation using Weblate (Finnish) Added translation using Weblate (Breton)
weblate
force-pushed
the
weblate-sssd-sssd-1-16
branch
from
d680968 to
176cc48
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds new translation files for Breton (br), Finnish (fi), Georgian (ka), Korean (ko), and Latvian (lv). While the addition of new languages is a positive step, there are a couple of critical issues with this automated update.
First, as noted in the specific comments, the POT-Creation-Date in all new .po files is from 2020. This indicates that the translation template file is outdated, which will result in incomplete translations as any strings added to the codebase since 2020 will be missing. It's crucial to regenerate the .pot file from the current source and then update these new language files accordingly.
Second, the po/LINGUAS file, which typically lists all supported languages for the build system, has not been updated to include these new languages. Without adding br, fi, ka, ko, and lv to po/LINGUAS, these new translations will likely be ignored by the build process and will not be shipped. This needs to be addressed for the translations to be effective.
Addressing these two points is essential for the correctness and completeness of this localization update.
| msgstr "" | ||
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: sssd-devel@lists.fedorahosted.org\n" | ||
| "POT-Creation-Date: 2020-10-12 12:09+0200\n" |
There was a problem hiding this comment.
The POT-Creation-Date is from 2020. This is quite old and suggests that the template file (.pot) used to generate this new translation file is outdated. This could lead to many new translatable strings from the source code being missing. It is highly recommended to regenerate the .pot file from the latest source and then regenerate this .po file to ensure all strings are included for translation.
| msgstr "" | ||
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: sssd-devel@lists.fedorahosted.org\n" | ||
| "POT-Creation-Date: 2020-10-12 12:09+0200\n" |
There was a problem hiding this comment.
The POT-Creation-Date is from 2020. This is quite old and suggests that the template file (.pot) used to generate this new translation file is outdated. This could lead to many new translatable strings from the source code being missing. It is highly recommended to regenerate the .pot file from the latest source and then regenerate this .po file to ensure all strings are included for translation.
| msgstr "" | ||
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: sssd-devel@lists.fedorahosted.org\n" | ||
| "POT-Creation-Date: 2020-10-12 12:09+0200\n" |
There was a problem hiding this comment.
The POT-Creation-Date is from 2020. This is quite old and suggests that the template file (.pot) used to generate this new translation file is outdated. This could lead to many new translatable strings from the source code being missing. It is highly recommended to regenerate the .pot file from the latest source and then regenerate this .po file to ensure all strings are included for translation.
| msgstr "" | ||
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: sssd-devel@lists.fedorahosted.org\n" | ||
| "POT-Creation-Date: 2020-10-12 12:09+0200\n" |
There was a problem hiding this comment.
The POT-Creation-Date is from 2020. This is quite old and suggests that the template file (.pot) used to generate this new translation file is outdated. This could lead to many new translatable strings from the source code being missing. It is highly recommended to regenerate the .pot file from the latest source and then regenerate this .po file to ensure all strings are included for translation.
| msgstr "" | ||
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: sssd-devel@lists.fedorahosted.org\n" | ||
| "POT-Creation-Date: 2020-10-12 12:09+0200\n" |
There was a problem hiding this comment.
The POT-Creation-Date is from 2020. This is quite old and suggests that the template file (.pot) used to generate this new translation file is outdated. This could lead to many new translatable strings from the source code being missing. It is highly recommended to regenerate the .pot file from the latest source and then regenerate this .po file to ensure all strings are included for translation.
2 participants
Translations update from Fedora Weblate for SSSD/sssd-1-16.
Current translation status: