Skip to content

scripts: fetch branch before checkout in release script#8394

Merged
pbrezina merged 1 commit intoSSSD:masterfrom
pbrezina:release-fetch
Jan 21, 2026
Merged

scripts: fetch branch before checkout in release script#8394
pbrezina merged 1 commit intoSSSD:masterfrom
pbrezina:release-fetch

Conversation

@pbrezina
Copy link
Member

actions/checkout does a sparse clone by default so the branch may not
be yet available.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses a potential issue where the target branch might not be available locally due to sparse cloning by adding a git fetch command before checkout. This improves the robustness of the release script. No high or critical severity issues were found in the changes.

@justin-stephenson justin-stephenson self-assigned this Jan 21, 2026
actions/checkout does a sparse clone by default so the branch may not
be yet available.

Reviewed-by: Justin Stephenson <jstephen@redhat.com>
@sssd-bot
Copy link
Contributor

The pull request was accepted by @pbrezina with the following PR CI status:


🟢 CodeFactor (success)
🟢 CodeQL (success)
🟡 osh-diff-scan:fedora-rawhide-x86_64:upstream (in_progress)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟡 rpm-build:fedora-42-x86_64:upstream (in_progress)
🟡 rpm-build:fedora-43-x86_64:upstream (in_progress)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟡 ci / intgcheck (centos-10) (in_progress)
🟡 ci / intgcheck (fedora-42) (in_progress)
🟡 ci / intgcheck (fedora-43) (in_progress)
🟡 ci / intgcheck (fedora-44) (in_progress)
🟢 ci / prepare (success)
🟡 ci / system (centos-10) (in_progress)
🟡 ci / system (fedora-42) (in_progress)
🟡 ci / system (fedora-43) (in_progress)
🟡 ci / system (fedora-44) (in_progress)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@pbrezina pbrezina merged commit 7d8e3c3 into SSSD:master Jan 21, 2026
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants