Bunch of assorted perf improvements of hot path functions#8443
Closed
alexey-tikhonov wants to merge 4 commits intoSSSD:masterfrom
Closed
Bunch of assorted perf improvements of hot path functions#8443alexey-tikhonov wants to merge 4 commits intoSSSD:masterfrom
alexey-tikhonov wants to merge 4 commits intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to introduce temporary debugging statements. This type of code should be removed before merging to maintain a clean and production-ready codebase. I have left comments on each of the added debug lines with suggestions for their removal. One of the statements in sysdb_ops.c is also unreachable, which is a more critical issue.
alexey-tikhonov
force-pushed
the
initgr-debug
branch
from
f3aa845 to
e047885
Compare
Both `perf` and manual measurement confirms ~6..8% perf gain in the test case: - INITGROUPS lookup for a user that is a member of 5k groups, no groups were cached; - debug_level = 3 - debug_microseconds = true Note `debug_microseconds = true` - without this setting impact isn't that dramatic.
alexey-tikhonov
force-pushed
the
initgr-debug
branch
from
5e072b6 to
218f1ba
Compare
In vast majority of cases strings are ascii and lowercase. In other cases overhead added should be negligible.
alexey-tikhonov
force-pushed
the
initgr-debug
branch
from
218f1ba to
9d1abc4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This helper is heavily used, including in hot paths. Since number of domains used is very limited, hash table used for caching should be very small and lookup much more efficient as compared with `sss_tc_utf8_str_tolower()`
alexey-tikhonov
changed the title
Member
Author
|
Superseded by #8447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.