[autobackport: sssd-2-9] sdap: do not require GID for non-POSIX group#8455
Conversation
There was a problem hiding this comment.
Code Review
This pull request is a backport that fixes an issue where SSSD would incorrectly require a GID for non-POSIX groups. The change in src/providers/ldap/sdap_async_groups.c correctly makes the GID retrieval conditional on the group being a POSIX group. A new test case has been added in src/tests/system/tests/test_identity.py to cover this scenario with nested non-POSIX groups, ensuring the fix is effective. The changes look correct and well-tested.
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this. sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group. Resolves: SSSD#8441 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit ad173e0)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
c5435c0 to
5791875
Compare
This is an automatic backport of PR#8442 sdap: do not require GID for non-POSIX group to branch sssd-2-9, created by @sumit-bose.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
ad173e0 - sdap: do not require GID for non-POSIX group
Backported commits
Original Pull Request Body
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this.
sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group.
Resolves: #8441