[autobackport: sssd-2-12] sdap: do not require GID for non-POSIX group#8456
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request backports a change to avoid requiring a GID for non-POSIX groups. The change in src/providers/ldap/sdap_async_groups.c correctly wraps the GID retrieval logic within a check for posix_group, which is the right approach to handle non-POSIX groups that lack a GID. A new test case has been added in src/tests/system/tests/test_identity.py to validate this fix by checking indirect group membership through a nested non-POSIX group. The test is well-structured and effectively covers the changed functionality. The changes look correct and I approve them.
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this. sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group. Resolves: SSSD#8441 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit ad173e0)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8442-to-sssd-2-12
branch
from
56815f2 to
7aa7344
Compare
4 participants
This is an automatic backport of PR#8442 sdap: do not require GID for non-POSIX group to branch sssd-2-12, created by @sumit-bose.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
ad173e0 - sdap: do not require GID for non-POSIX group
Backported commits
Original Pull Request Body
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this.
sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group.
Resolves: #8441