Skip to content

1181 crashing achievements list if name null#1186

Merged
jernejk merged 3 commits intomainfrom
1181-crashing-achievements-list-if-name-null
Jan 31, 2025
Merged

1181 crashing achievements list if name null#1186
jernejk merged 3 commits intomainfrom
1181-crashing-achievements-list-if-name-null

Conversation

@jernejk
Copy link
Member

@jernejk jernejk commented Jan 31, 2025

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Technically related to #1181 as achievement list was crashing locally and that might happen as well in staging and prod as they are a couple of months out of date. (DevOps deployments failed and not fixed)

  1. What was changed?

✏️ Make sure we don't crash on null for Name nor Code.

  1. Did you do pair or mob programming?

✏️ No.

image

Copy link
Member

@vladislav-kir vladislav-kir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jernejk jernejk merged commit f34d494 into main Jan 31, 2025
6 checks passed
@jernejk jernejk deleted the 1181-crashing-achievements-list-if-name-null branch January 31, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants