🐛 Fix offline crash on Network page #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurs when navigating to the Network page a second time while offline. The root cause was event handlers (OnCollectionUpdated and OnError) being subscribed inside a one-time initialization block, preventing them from being re-subscribed after OnDisappearing() unsubscribed them. The fix moves these subscriptions outside the conditional block to ensure they're re-attached on every page appearance.
Key Changes:
- Event handler subscriptions moved from inside the one-time
if (Segments is null || Segments.Count == 0)block to unconditional execution inInitialise() - Aligns with the established pattern used in
QuizViewModelandRedeemViewModel
Freego1783
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1470
Fixes a crash when navigating to the Network page a second time while offline, as the error event handler doesn't get re-subscribed to the collection.
No