🐛 Improve "scroll to me" #1482
Merged
🐛 Improve "scroll to me" #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of the "scroll to me" functionality on the leaderboard by fixing the scroll logic and ensuring proper thread synchronization. The changes address issues where the scroll operation might fail due to timing problems or incorrect loop logic.
Key Changes:
- Fixed the while loop logic in ScrollToMe to check for limit conditions first and update myCard at the correct position
- Added MainThread invocation with a small delay before scrolling to ensure UI is ready
- Moved ScrollTo event handler subscription earlier in OnAppearing to ensure it's registered before Initialise completes
- Removed unused Microsoft.Maui.Controls.Internals import
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MobileUI/Features/Leaderboard/LeaderboardViewModel.cs | Refactored ScrollToMe logic to check limit first, update myCard at loop end, and add thread-safe delayed scrolling |
| src/MobileUI/Features/Leaderboard/LeaderboardPage.xaml.cs | Moved ScrollTo event subscription earlier and removed unused import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1435
Improves reliability of "scroll to me" button
No