Skip to content

Fix links and embedded YouTube videos in BoxEmbed #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PothieuG merged 2 commits into from
Jan 6, 2026
Merged

Fix links and embedded YouTube videos in BoxEmbed #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342d7bd
make links and embedded YouTube videos render correctly inside boxEmbed
Aibono1225 Jan 6, 2026
97a8615
Merge branch 'main' into 2263-render-link-and-video-in-box
Aibono1225 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions components/embeds/boxEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { TinaMarkdown } from "tinacms/dist/rich-text";
import { toolbarFields } from "@/tina/collection/shared/toolbarFields";
import MarkdownComponentMapping from "../tina-markdown/markdown-component-mapping";
import { Figure, inlineFigureDefaultItem, inlineFigureFields } from "./figure";
import { youtubeEmbedTemplate } from "./youtubeEmbed";
import { imageEmbedTemplate } from "./imageEmbed";

type BoxVariant = "greybox" | "info" | "todo" | "china" | "codeauditor" | "highlight" | "warning" | "tips";

Expand Down Expand Up @@ -88,19 +90,14 @@ export function BoxEmbed(props: any) {
const figure: string = data?.figure || "";
const figurePrefix: any = data?.figurePrefix || "none";

const components = {
...MarkdownComponentMapping,
a: ({ children }: any) => <span>{children}</span>,
};

return (
<>
<div className={`p-4 rounded-sm my-4 ${config.containerClass}`}>
<div className="flex items-start">
{config.icon}
<div className={`[&_p:last-child]:mb-0 ${config.textClass ?? ""}`}>
<div>
<TinaMarkdown content={data.body} components={components} />
<TinaMarkdown content={data.body} components={MarkdownComponentMapping} />
</div>
</div>
</div>
Expand Down Expand Up @@ -148,6 +145,7 @@ export const boxEmbedTemplate: Template = {
label: "Body",
type: "rich-text",
toolbarOverride: toolbarFields,
templates: [youtubeEmbedTemplate, imageEmbedTemplate],
},
...(inlineFigureFields as any),
],
Expand Down
2 changes: 1 addition & 1 deletion tina/tina-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading