S⚠️ ◾ Added MCP OAuth integration with backend #627
Conversation
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
github-actions
bot
changed the title
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
babakamyljanovssw
changed the title
|
🚀 Pre-release build is available for this PR: |
github-actions
bot
changed the title
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
Hi there! This PR has been here a while. Did you know you should avoid merge debt? Please review and merge or close. Thanks! |
|
🚀 Pre-release build is available for this PR: |
| ): Promise<OAuthTokens> { | ||
| const start = Date.now(); | ||
| console.log(`[McpOAuth] Polling for tokens for server ${serverId} (Timeout: ${timeoutMs}ms)`); | ||
| while (Date.now() - start < timeoutMs) { |
There was a problem hiding this comment.
this is blocking code ... i don't know if thats a good idea or if it's better to use something like setInterval
There was a problem hiding this comment.
Agree, implemented more robust and efficient solution:
- Whenever token is saved in the safe storage, it sends an event about it
- Then here instead of polling tokens every second to check if it exists, we just wait for the event with the given timeout
- When event received, Promise resolves immediately
|
|
||
| return ( | ||
| <McpCard | ||
| isReadOnly |
There was a problem hiding this comment.
Is this now using the oAuth and we do not need to specify the "catalog" ssw or ssw2 anymore?
There was a problem hiding this comment.
Currently DevOps using stdio transport protocol not remote http MCP server. OAuth is only for remote MCP servers. Just checked their docs, seems like they don't have support for remote http server yet.
https://github.com/microsoft/azure-devops-mcp?tab=readme-ov-file#steps
There was a problem hiding this comment.
Removed isReadOnly so users can edit DevOps Mcp Server
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
|
🚀 Pre-release build is available for this PR: |
✏️ Gemini 3 Flash
✏️ #624
✏️ Removed old flow for MCP OAuth, and integrated with backend instead
✏️ Removed GitHub client id and secret from pipeline
✏️ @Lewkans