Improve Rem support + tests for comments #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for this. Good change, and I appreciate the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Rem comments (aka. remarks) to support comment blocks as it is currently supported in the VBE.
Note that I had to change the order of the include statements to avoid
remarkCommentstaking over.I've also added support for the case where a line number preceeds the Rem comment.
Regarding the unit tests, I've used
'as the comment token, but I can change it to//if needed.Also note I'm using the negation pattern with
- comment.line.remark.vbafor the lineRem Comment at the end of a linesince it's not supported.