Skip to content

Hot fix #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2025
Merged

Hot fix #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef96799
Fixes #65
SSlinky Apr 12, 2025
702b323
Couple of negative tests to ensure #61 doesn't break again
SSlinky Apr 12, 2025
5d1396a
1.5.9
SSlinky Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"icon": "images/vba-lsp-icon.png",
"author": "SSlinky",
"license": "MIT",
"version": "1.5.8",
"version": "1.5.9",
"repository": {
"type": "git",
"url": "https://github.com/SSlinky/VBA-LanguageServer"
Expand Down
2 changes: 1 addition & 1 deletion server/src/antlr/vba.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ constantName
// ;

constDeclaration
: variableModifier? CONST wsc constItemList
: (variableModifier wsc)? CONST wsc constItemList
;

constItemList
Expand Down
16 changes: 16 additions & 0 deletions test/fixtures/ScopeDiagnostics.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Attribute VB_Name = "ScopeDiagnostics"

Option Explicit

Private Const ABC As Long = 0

Public Enum XfaskofeaFoo
Enum1 = 2 ^ 1
Bar = 2 ^ 2
Bar = 2 ^ 3
End Enum

Public Sub XfaskofeaFoo(Optional test_param As Variant = -0.1)
Attribute XfaskofeaFoo.VB_Description = "docstring."
Call SomeSub(param, -0.15)
End Sub