Skip to content

Fix feature: Explore Filter - Fixing and optimizing defects #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix feature: Explore Filter - Fixing and optimizing defects #1006

wants to merge 4 commits into from

Conversation

masaabu
Copy link
Contributor

@masaabu masaabu commented Apr 8, 2025

Fixed a bug and made the code more readable.

Fixed Bugs

  • Settings are displayed even though no filter is applied
  • Author filter was filtering on author name text
  • Filter was case sensitive.

Other changes

  • Default state of filter changed to null
  • Changed filter checks to be more readable
  • Removed unnecessary code

@masaabu masaabu changed the title Fixing and optimizing defects Feature: Explore Filter - Fixing and optimizing defects Apr 8, 2025
@masaabu masaabu changed the title Feature: Explore Filter - Fixing and optimizing defects Fix feature: Explore Filter - Fixing and optimizing defects Apr 8, 2025
@MaterArc MaterArc added type: enhancement Makes an existing feature better priority: 2 The 2nd most important. scope: feature labels Jun 10, 2025
@MaterArc MaterArc modified the milestone: ScratchTools v4.2.0 Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaterArc MaterArc MaterArc approved these changes

Assignees
No one assigned
Labels
priority: 2 The 2nd most important. scope: feature type: enhancement Makes an existing feature better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaabu @MaterArc