Skip to content

SHS-6056: Dashboard: Importer block: Events#1755

Merged
cienvaras merged 30 commits intoSHS-5913_Dashboard-initiativefrom
SHS-6056--event-import-dashboard
Mar 17, 2025
Merged

SHS-6056: Dashboard: Importer block: Events#1755
cienvaras merged 30 commits intoSHS-5913_Dashboard-initiativefrom
SHS-6056--event-import-dashboard

Conversation

@codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Feb 21, 2025

Summary

  • Adds event importer information into the dashboard importers block
  • Refactors how importer information is retrieved by reworking each importer into a plugin with an interface and base class
  • Requires work done over in SHS-6056: Allow external access to Localist API methods SU-SWS/stanford_fields#58 that make some of the Widget methods public. Once merged, in this PR, you can remove the changes in composer.json.

Need Review By (Date)

3/5/2025

Urgency

high

Steps to Test

  1. Visit the dashboard for several of the test sites: /admin/dashboard
  2. Scroll to the Importers section
  3. Verify that there are 2 importers now, People and Events

Screenshot 2025-02-27 at 5 09 13 PM

  1. Not all sites will have event imports, but West and History have them
  2. Change the importer temporarily: Visit /admin/structure/migrate/localist-events and for one of the importers, add a few different filters
  3. Save the config page
  4. Go back to the dashboard and refresh
  5. Verify that filters are showing up in the list of event importers via a comma separated list

Screenshot 2025-02-27 at 5 10 09 PM

  1. Verify that on the base Tugboat instance, there are no importers configured and the messaging exists to tell you so

Screenshot 2025-02-27 at 5 09 05 PM

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 01:07 Destroyed
@codechefmarc codechefmarc changed the base branch from develop to SHS-5913_Dashboard-initiative February 21, 2025 01:07
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 02:30 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 02:37 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 02:37 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 23:56 Destroyed
@codechefmarc codechefmarc self-assigned this Feb 21, 2025
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 23:57 Destroyed
@codechefmarc codechefmarc marked this pull request as ready for review February 28, 2025 01:10
…humsci into SHS-6056--event-import-dashboard
@ahughes3 ahughes3 temporarily deployed to Tugboat February 28, 2025 17:07 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Great work, thanks!

@ahughes3 Ready for you.

…humsci into SHS-6056--event-import-dashboard
@ahughes3 ahughes3 temporarily deployed to Tugboat March 4, 2025 17:11 Destroyed
@cienvaras cienvaras requested a review from ahughes3 March 4, 2025 17:51
@cienvaras cienvaras assigned ahughes3 and unassigned codechefmarc Mar 4, 2025
…humsci into SHS-6056--event-import-dashboard
@ahughes3 ahughes3 temporarily deployed to Tugboat March 5, 2025 21:34 Destroyed
@ahughes3
Copy link
Collaborator

@cienvaras a few minor updates for this one before merging into the main dashboard branch

  • Change the column title Filters to Departments/Groups
  • Remove column for Recurring event treatment: This info isn't relevant to the Site Editors as H&S Web team sets the importers up

Would it be possible to also include

  • Last imported date
  • Number of Imported items
  • Number of failed imported items?

@ahughes3 ahughes3 assigned cienvaras and unassigned ahughes3 Mar 10, 2025
…humsci into SHS-6056--event-import-dashboard
@ahughes3 ahughes3 temporarily deployed to Tugboat March 11, 2025 23:16 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat March 13, 2025 03:36 Destroyed
@cienvaras
Copy link
Collaborator

@ahughes3 "Filters" renamed to "Departments/Groups" and "Recurring event treatment" column removed. Ready for review again.

@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Mar 13, 2025
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras lgtm, approved to move merge into the main dashboard branch

@ahughes3 ahughes3 assigned cienvaras and unassigned ahughes3 Mar 14, 2025
@cienvaras cienvaras merged commit 11be6f3 into SHS-5913_Dashboard-initiative Mar 17, 2025
31 of 33 checks passed
@cienvaras cienvaras deleted the SHS-6056--event-import-dashboard branch March 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants