SRC-130: Moved search and hamburger for lg and md breakpoints

[jenbreese]

READY FOR REVIEW

Summary

• From 1199px down to 992px the mobile hamburger is on top of search.
• Med breakpoint has the hamburger up in the brandbar

Review By (Date)

• when time

Criticality

• Normal

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Navigate to a page and change the browser window size.
4. Verify the hamburger and search are no longer on top of each other.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SRC-130

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[mdyoung3]

Hi @jenbreese

Stanford Basic doesn't show the search field until after the hamburger menu goes away (see video below).

We should probably match that (unless there's some requirement here I'm not away of).

[jenbreese]

@mdyoung3 I don't think they need to match. In this subtheme, it was over written specifically.

[buttonwillowsix]

Approved by Marc!