Merged
Conversation
* Add aria-label to search listbox * Add higher z-index to megamenu panel so 1st level parent and search icon don't show through under in case user add custom spacing to make menu wrap to 2nd line * Add svg title for external link icon in CTA * Wrap icon card section in ul * Add new field itemHeadingLevel that selects head level for all the child items; auto calculate itemHeadingLevel is headingLevel is provided and if a title exists * linter * when content menu is expanded, the aria-label should read "close section menu" instead of just "close" (more descriptive) * Restrict gap between desktop menu items to horizontal gap * Simplified function to get item heading level * Add aria-labelledby undefined to listbox * See if null for aria-labelledby work * revert
✅ Deploy Preview for adapt-giving ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test