Skip to content

Fix empty anchor nav still showing in top navigation#516

Merged
pookmish merged 2 commits into10.xfrom
D8CORE-8537-empty-h2-fix
Feb 11, 2026
Merged

Fix empty anchor nav still showing in top navigation#516
pookmish merged 2 commits into10.xfrom
D8CORE-8537-empty-h2-fix

Conversation

@hailstorm46
Copy link
Collaborator

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • Fixes the issue found where the top anchor nav still shows when there are no H2 elements.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@pookmish pookmish merged commit 6918a03 into 10.x Feb 11, 2026
4 checks passed
@pookmish pookmish deleted the D8CORE-8537-empty-h2-fix branch February 11, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants