SWSDEVOPS-150 - trustee profile update retry

[mdyoung3]

READY FOR REVIEW

Summary

• Update to trustee profile, incorporating changes from Stanford Profile
• Minor Drupal update (10.3 -> 10.4)

Review By (Date)

March 17

Criticality

• How critical is this PR on a 1-10 scale? Also see Severity Assessment.
• E.g., it affects one site, or every site and product?

Urgency

• How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

1. Review code.
2. Review sites.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[joegl]

I believe this configuration is for the upgrade_status module which is only enabled on dev/local. This configuration belongs in those config_split's then and not here.

[joegl]

It doesn't look like the config_split.config_split.stage.yml changes got pulled in (which most notably enable the shield module on staging).

[joegl]

Only a few small things I noticed in the code. I left comments on both this and the ace-botgryphon PR (even though I know you're still working on that one).

I was able to successfully set up the repo locally, run a composer install, run a drush si trustee_profile and sync the trustees site to my local without issue. I also reviewed the trustees-dev site. The only thing I noticed during the site reviews was you may want to address this "warning" on the status report page (not a big deal though):

State cache flag $settings['state_cache'] is not set. It is recommended to be set to TRUE in settings.php unless there are too many state keys. Drupal 11 will default to having state cache enabled.```

All-in-all it looks good for such a big update.

[joegl]

LGTM.