sui-theme v9 custom-properties available#2754
Open
andresin87 wants to merge 150 commits intomasterfrom
Open
Conversation
Contributor
|
🤩 |
|
make tag compatible without theme-v7 deprecated sui-theme module
…e-utils # Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Css native custom properties
🔍 ShowTASK:
Description, Motivation and Context
This PR is using @s-ui/theme@9.0.0-beta-2 which is a proposal to get ready to use css native custom tokens in brand web-apps and brand themes.
Those theme changes can be inspected in SUI-Components/sui#1804
The main handicap is the usage of SASS color functions and css
rgbacolor standard.### Replacing errors
When experiencing any problem related to this, the solution is color-mix CSS native color manipulation syntax. EX:
Important
color-mix Browser Compatibility
whatever { background-color: rgba(0,0,0,.3) }can be replaced to
whatever { background-color: color-mix(in srgb, black 70%, transparent) }also, for scss native color manipulation functions
whatever { background-color: mix($white, $color-primary, $mix-factor); }can be replaced to
whatever { background-color: color-mix(in srgb, $white #{'#{$mix-factor)}%'}, $color-primary); }Other utils
color-mix allows to nest its inner values
Types of changes
Screenshots - Animations