Improve connection logging at boot time #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End users need to know if the client service is working or not, and they do so by running `systemctl status velociraptor-client`. At boot time the client starts before the network and there is a "network is unreachable" message. We were logging this at ERROR level because INFO level messages won't show without --verbose, and that level is too verbose and spams the journal, see SUSE#65 . But end users only see error messages without any positive messages to say a connection was made, and they assume there is a problem. Fix this by writing failure/waiting/connected messages to stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End users need to know if the client service is working or not, and they do so by running
systemctl status velociraptor-client. At boot time the client starts before the network and there is a "network is unreachable" message. We were logging this at ERROR level because INFO level messages won't show without --verbose, and that level is too verbose and spams the journal, see #65 . But end users only see error messages without any positive messages to say a connection was made, and they assume there is a problem. Fix this by writing failure/waiting/connected messages to stderr.