WIP: Implement aws terraform peering#353
Open
BillAnastasiadis wants to merge 1 commit intoSUSE:mainfrom
Open
Conversation
BillAnastasiadis
had a problem deploying
to
production
GitHub Actions
Error
BillAnastasiadis
had a problem deploying
to
production
GitHub Actions
Failure
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
aws_qesap_peering
branch
from
c8effea to
29784b5
Compare
BillAnastasiadis
had a problem deploying
to
production
GitHub Actions
Failure
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
had a problem deploying
to
production
GitHub Actions
Error
BillAnastasiadis
force-pushed
the
aws_qesap_peering
branch
from
29784b5 to
5dc0e09
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
mpagot
reviewed
May 5, 2025
| depends_on = [aws_vpc_peering_connection.ibsm] | ||
| } | ||
|
|
||
| resource "aws_route" "from_ibsm_" { |
Collaborator
There was a problem hiding this comment.
Suggested change
| resource "aws_route" "from_ibsm_" { | |
| resource "aws_route" "from_ibsm" { |
mpagot
reviewed
May 5, 2025
| route_table_id = aws_route_table.route-table.id | ||
| destination_cidr_block = data.aws_vpc.ibsm[0].cidr_block | ||
| vpc_peering_connection_id = aws_vpc_peering_connection.ibsm[0].id | ||
| depends_on = [aws_vpc_peering_connection.ibsm] |
Collaborator
There was a problem hiding this comment.
try to remove
depends_on = [aws_vpc_peering_connection.ibsm]
mpagot
reviewed
May 5, 2025
| destination_cidr_block = local.vpc_address_range | ||
| vpc_peering_connection_id = aws_vpc_peering_connection.ibsm[0].id | ||
|
|
||
| lifecycle { |
Collaborator
There was a problem hiding this comment.
Thanks for the explanation you give me off line https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle
We can try to survive without it maybe, please try to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ticket optionally adds the resources/logic necessary for AWS IBSM peering in qe-sap-deployment (terraform).
To test this manually, run qe-sap-deployment locally using an AWS config file from a job that uses ibsm peering, and simply add the
ibsm_vpc_idvariable to it, in the terraform variables section. After running terraform apply, peering between the node(s) and ibsm should be immediately functional.