Open
Conversation
BillAnastasiadis
force-pushed
the
sudogcp
branch
from
8c1d928 to
0f1b43b
Compare
mpagot
reviewed
Nov 4, 2025
| delay: 5 | ||
| until: sudo_test.rc == 0 | ||
| changed_when: false | ||
| failed_when: sudo_test.rc != 0 |
Collaborator
There was a problem hiding this comment.
Sound sequential more than declarative.
Can we restrict it to GCP only?
I do not feel comfortable to disable gathering only to manually re-enable it later on, what if anything went wrong?
alvarocarvajald
changed the title
mpagot
reviewed
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a task to wait for paswordless sudo to be available before moving forward with the rest of the ansible execution. It also disables automatic fact-gathering, and moves it aftair the above task.
https://openqaworker15.qa.suse.cz/tests/349582
https://openqaworker15.qa.suse.cz/tests/349583
https://openqaworker15.qa.suse.cz/tests/349584