Use sap_storage_setup role in qe-sap-deployment#443
Draft
Use sap_storage_setup role in qe-sap-deployment#443
Conversation
lilyeyes
force-pushed
the
enable-upstream-role-use-for-sap_storage_setup
branch
2 times, most recently
from
ef832c0 to
dca745b
Compare
TEAM-10887 - [research] Check the qe-sap-storage role in the qe-sap-deployment repo
lilyeyes
force-pushed
the
enable-upstream-role-use-for-sap_storage_setup
branch
from
dca745b to
4a937f6
Compare
mpagot
reviewed
Feb 14, 2026
|
|
||
| ansible.builtin.include_role: | ||
| name: qe_sap_storage | ||
| # name: qe_sap_storage |
Collaborator
mpagot
reviewed
Feb 14, 2026
| name: "{{ item }}" | ||
| state: present | ||
| environment: | ||
| ZYPP_LOCK_TIMEOUT: '120' |
Collaborator
There was a problem hiding this comment.
should be no more needed now that we have #439 merged
mpagot
reviewed
Feb 14, 2026
| - name: Set host type | ||
| ansible.builtin.set_fact: | ||
| sap_storage_setup_host_type: >- | ||
| {% if 'hana01' in inventory_hostname %} ["hana_primary"] |
Collaborator
There was a problem hiding this comment.
Look for is_primary: "{{ groups.hana[0] == inventory_hostname }}" in other part of the code.
Collaborator
Author
|
Thank you Michele, it is just a simple try. I created this PR just in case I forgot it after vacation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEAM-10887 - [research] Check the qe-sap-storage role in the qe-sap-deployment repo