Feat/add testing structure to v2#36
Draft
victorstevansuse wants to merge 26 commits intostackpack-v2from
Draft
Conversation
…xtures, and test stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive test suite, developer tooling, and local test infrastructure
Summary
init.shinstall/uninstall logic with mockedstsCLInpm-groovy-linttask check— single command to validate everything before pushing. Kind of a very primitive static analysis.task deploy— safe deployment that validates before uploadingStill W.I.P
Bugs found and fixed
products.styreferenced...request-sucess-rate(typo) instead of...success-rate— the Milvus success rate metric was silently missing from the UIsuse-ai-product-id-extractor.groovyhad an unusedtypeNamevariable flagged by the linterinit.shusedxargswhich is not available in the container base imageWhat's included
Test infrastructure (
tests/)Taskfile targets
task checktask check SILENT=1task deploytask linttask lint-fixtask test-statictask test-inittask test-integrationtask infra-uptask infra-downtask infra-statusLocal test environment
task infra-updeploys into a K3d cluster:DEPLOY_MILVUS=true, etc.)The OTel collector image defaults to
otel/opentelemetry-collector-contrib:0.147.0and can be switched to the custom build (e.g. otelcol-suse-ai) viaOTEL_COLLECTOR_IMAGE.What the static tests enforce
From
knowledge/CERTAINS.md:componentActionsfieldprovisioning/prefixqueryVersionfieldaboutsectionFrom
knowledge/RECOVERY_PROTOCOL.mdandknowledge/MONITOR_CREATION_GUIDE.md:events,externalComponent,relatedResourcesdescription,status,intervalSeconds,arguments.metricnodes:root keyStructural validation:
.toString()on externalIdSnapshot regression detection (golden files):
Test plan
task checkpasses (lint + 34 static tests + 10 init tests)task check SILENT=1runs with minimal outputtask lint-fixauto-fixes Groovy style issuestask infra-updeploys successfully andtask infra-statusshows all pods runningtask deployagainst a test instance to verify the Milvus metric fix