Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the architecture for acquiring localized strings by replacing the previous singleton pattern with a dependency injection structure. Key changes include the removal of the legacy LocalizableText view, updating dependency registrations to include a new LocalizedStrProvider, and modifying various view models and builders to use the injected provider for localized string retrieval.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Projects/Features/Setting/Feature/Sources/View/LocalizableText.swift | Removal of legacy view using singleton-based localization. |
| Projects/Features/Setting/Feature/Sources/SettingBuilder.swift | Updated dependency injection to supply localized string provider. |
| Projects/Features/Setting/Example/Sources/DI/Assemblies.swift | Added DI registration for LocalizedStrProvider. |
| Projects/Features/Root/Feature/Sources/TabBar/* | Refactored tab bar components to use injected localized string provider and updated enum cases. |
| Projects/Features/Root/Feature/Sources/RootViewModel.swift | Switched to injected localized string provider for splash screen text generation. |
| Projects/Features/CoinDetail/Feature/Sources/CoinDetailPageViewModel.swift | Updated localized string retrieval to use dependency injection (note potential misspelling in key). |
| Projects/Features/AllMarketTicker/* | Refactored market ticker view models and builders to utilize LocalizedStrProvider. |
Comments suppressed due to low confidence (1)
Projects/Features/Setting/Feature/Sources/View/LocalizableText.swift:1
- Ensure that the removal of LocalizableText.swift is intentional and that its functionality has been fully migrated to the new architecture without leaving any dangling dependencies.
Entire file removed
Projects/Features/CoinDetail/Feature/Sources/CoinDetailPageViewModel.swift
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경된 점
LocalizedString획득 아키텍처 리팩토링
키값의 경우
enum계층을 사용하여 사용성 및 가시성을 높였습니다.