-
Notifications
You must be signed in to change notification settings - Fork 0
Test for moving files #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=========================================
- Coverage 80.7% 80.6% -0.1%
Complexity 135 135
=========================================
Files 16 16
Lines 570 568 -2
Branches 66 66
=========================================
- Hits 460 458 -2
Misses 69 69
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (os.contains("mac")) { | ||
| // OSX is SLOW on it's watches | ||
| delayFactor *= 2; | ||
| delayFactor *= 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes the OS test a lot slower again.
In a different PR we should try and remove all the sleeps and replace them by accurate awaits. as the sleeps get very long, especially with a high delayFactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, made an issue.
DavyLandman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR:
JDKFileWatch(which coincidentally came to light because of the new test, but isn't directly related to file moves) that caused events forfoo/bar/baz.txtto be reported as events forfoo/barandbaz.txtas root path and relative path, instead offoo/bar/baz.txtand(empty).