Skip to content

Conversation

@sungshik
Copy link
Contributor

This PR:

  • adds a test to validate if file moves are properly reported;
  • fixes an issue in JDKFileWatch (which coincidentally came to light because of the new test, but isn't directly related to file moves) that caused events for foo/bar/baz.txt to be reported as events for foo/bar and baz.txt as root path and relative path, instead of foo/bar/baz.txt and (empty).

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.6%. Comparing base (0acdfcb) to head (c4809f2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #42     +/-   ##
=========================================
- Coverage     80.7%   80.6%   -0.1%     
  Complexity     135     135             
=========================================
  Files           16      16             
  Lines          570     568      -2     
  Branches        66      66             
=========================================
- Hits           460     458      -2     
  Misses          69      69             
  Partials        41      41             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sungshik sungshik marked this pull request as ready for review April 21, 2025 14:19
@sungshik sungshik requested a review from DavyLandman April 21, 2025 14:20
if (os.contains("mac")) {
// OSX is SLOW on it's watches
delayFactor *= 2;
delayFactor *= 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the OS test a lot slower again.

In a different PR we should try and remove all the sleeps and replace them by accurate awaits. as the sleeps get very long, especially with a high delayFactor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, made an issue.

Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sungshik sungshik merged commit ec14259 into main Apr 22, 2025
15 checks passed
@sungshik sungshik deleted the file-move-test branch April 22, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants