Increase Timeouts and Fix Modal Deployment Bug#205
Merged
klieret merged 1 commit intoSWE-agent:mainfrom Jun 25, 2025
Merged
Conversation
klieret
approved these changes
Jun 24, 2025
Member
klieret
left a comment
klieret
left a comment
There was a problem hiding this comment.
Sounds good, thank you! Really appreciate the feedback & changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the two following changes:
Increased timeouts x2 from
1800to3600(30 min to 1 hr)This is based on our observation that users often hit the initial 30 minute timeouts and have to manually adjust.
ModalDeployment Initialization Bug
When a deployment is already started, warn on calling
deployment.start()twice to prevent orphaned deployment with no cleanup.