Make remote runtime fully async with aiohttp + testing

[klieret]

• Make remote runtime fully async with aiohttp
• [pre-commit.ci] auto fixes from pre-commit.com hooks
• CI: Properly cleanup sessions

[saltzm]

@klieret I found the issue:

1. The server closes the connection because the FileNotFoundException is seen as "unhandled". This was true in the old code as well.
2. We try to reuse the same aiohttp session to close the runtime during test teardown, but that session is associated with a closed connection, and so the close request fails with Connection reset by peer

In the old version of the code, the requests library was being used, which always creates a new session per request, so it would just recreate a fresh connection for the close request, and avoid this issue.

So I just changed the new code to match the old behavior and always create a new session per request.

This fixed the non_existent_file tests, but locally at least there are 18 failures in tests/test_execution.py that also exist in the main branch:

FAILED tests/test_execution.py::test_execute_command_with_empty_string_in_session - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == '\n'
FAILED tests/test_execution.py::test_execute_command_with_newline_in_session - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == '\nx'
FAILED tests/test_execution.py::test_execute_command_with_many_newlines_in_session - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == '\n\nx\n\n\n'
FAILED tests/test_execution.py::test_execute_command_with_whitespace_in_session - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == '  x'
FAILED tests/test_execution.py::test_execute_command_with_leading_space_in_session - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == '\n \nhello\nworld\n'
FAILED tests/test_execution.py::test_run_in_shell_timeout - swerex.exceptions.NoExitCodeError: timeout while getting exit code
FAILED tests/test_execution.py::test_run_in_shell_interactive_command_timeout - Failed: DID NOT RAISE <class 'swerex.exceptions.CommandTimeoutError'>
FAILED tests/test_execution.py::test_multiple_isolated_shells - AssertionError: assert '\r\n42\n\x1b...ReX\x1b\\\r\n' == '42\n'
FAILED tests/test_execution.py::test_multiple_commands_with_linebreaks_in_shell - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'test1\ntest2\n'
FAILED tests/test_execution.py::test_bash_multiline_command_eof - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'hello world\nhello world 2\n'
FAILED tests/test_execution.py::test_run_just_comment - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == ''
FAILED tests/test_execution.py::test_run_in_shell_multiple_commands - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'hello world\nhello again\n'
FAILED tests/test_execution.py::test_run_in_shell_while_loop - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'hello world\...hello world\n'
FAILED tests/test_execution.py::test_with_bashlex_errors - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'hw\nasdf\n'
FAILED tests/test_execution.py::test_fail_bashlex_errors - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == ''
FAILED tests/test_execution.py::test_echo_new_lines - AssertionError: assert '\r\n\x1bkec2...ReX\x1b\\\r\n' == 'hello\nworld\n'
FAILED tests/test_execution.py::test_interrupt_session - AssertionError: assert '\r\nasdf\n\x...ReX\x1b\\\r\n' == 'asdf\n'
FAILED tests/test_execution.py::test_interrupt_pager - swerex.exceptions.NoExitCodeError: failed to parse exit code from output '\r\n\x1b=\rblargh\n(END)\r\x07\r(END)\r\r(END)\x07\r(END)\r...skipping...\n\n                   SUMMARY OF LESS COMMANDS\n\n      Commands marked wi...
===================================================================================== 18 failed, 29 passed, 1 xfailed, 34 warnings in 23.86s ======================================================================================

I went ahead and pushed to this branch because it seemed easiest but can also pull my changes back out into my fork if that's better. Thanks! Let me know if there are any other issues.

CC: @joyliu-q

[saltzm]

Looks like tests all passed in CI, let me know if you have any other feedback 🙂

[saltzm]

Hi! Just checking on this

[klieret]

Hi @saltzm thank you so much for the PR! I've just merged it :) Will look at the other PRs in a second.

Sorry again that this took for forever, but I'm really happy for the improvements!

[saltzm]

All good, thanks!