Fix Hardcoded Region in Task Definition Log Group#259
Merged
klieret merged 1 commit intoSWE-agent:mainfrom Sep 18, 2025
Merged
Conversation
Fix hardcoded region in task definition log group. Region was previously hardcoded to us-east-2. Region is now dynamically determined from the environment and aligned with other resources in the setup
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hardcoded region issue in the AWS ECS task definition logging configuration. The region was previously hardcoded to "us-east-2" but is now dynamically determined from the AWS environment to align with other resources.
- Dynamically retrieves the AWS region from the ECS client instead of using a hardcoded value
- Updates both the task definition log group configuration and CloudWatch log URL generation
- Ensures regional consistency across all AWS resources in the setup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/swerex/utils/aws.py | Updates task definition to use dynamic region for awslogs-region configuration |
| src/swerex/deployment/fargate.py | Passes dynamic region to CloudWatch log URL generation function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
looking good, just confirmed that this remains at us-east-2 for me, so should hopefully work for our team |
klieret
approved these changes
Sep 18, 2025
Member
|
CC: @carlosejimenez |
lurf21
added a commit
to lurf21/SWE-ReX
that referenced
this pull request
Jan 30, 2026
)" This reverts commit d7987c0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hardcoded region in task definition log group.
Region was previously hardcoded to us-east-2. Region is now dynamically determined from the environment and aligned with other resources in the setup
#257