Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the shell executable configurable in Docker deployments by adding an exec_shell configuration option. This allows users to customize which shell and arguments are used when executing commands in Docker containers.
- Added a configurable
exec_shellfield toDockerDeploymentConfigwith sensible defaults - Updated command execution to use the configured shell instead of hardcoded
/bin/sh -c
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/swerex/deployment/config.py | Added exec_shell configuration field with default value ["/bin/sh", "-c"] |
| src/swerex/deployment/docker.py | Updated _get_swerex_start_cmd to use configurable shell from config instead of hardcoded values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lurf21
added a commit
to lurf21/SWE-ReX
that referenced
this pull request
Jan 30, 2026
This reverts commit a25feea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#263