Skip to content

fix: make docker_internal_host configurable with default value #253 issue #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klieret merged 2 commits into from
Oct 6, 2025
Merged

fix: make docker_internal_host configurable with default value #253 issue #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ca8e3
fix: make docker_internal_host configurable with default value #253 i…
SkipperNZ Oct 4, 2025
f7155ff
Apply suggestion from @klieret
klieret Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/swerex/deployment/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ class DockerDeploymentConfig(BaseModel):
"""The container runtime to use (docker or podman)."""
exec_shell: list[str] = ["/bin/sh", "-c"]
"""The shell executable and arguments to use for running commands."""
docker_internal_host: str = "http://127.0.0.1"
"""The host to use for connecting to the runtime."""

type: Literal["docker"] = "docker"
"""Discriminator for (de)serialization/CLI. Do not change."""
Expand Down
7 changes: 6 additions & 1 deletion src/swerex/deployment/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,12 @@ async def start(self):
self._hooks.on_custom_step("Starting runtime")
self.logger.info(f"Starting runtime at {self._config.port}")
self._runtime = RemoteRuntime.from_config(
RemoteRuntimeConfig(port=self._config.port, timeout=self._runtime_timeout, auth_token=token)
RemoteRuntimeConfig(
host=self._config.docker_internal_host,
port=self._config.port,
timeout=self._runtime_timeout,
auth_token=token,
)
)
t0 = time.time()
await self._wait_until_alive(timeout=self._config.startup_timeout)
Expand Down