feat: full private repository support#220
Conversation
Add end-to-end private repository support across all profile types. Visibility-aware git authentication ensures private repos get private mirrors, SSH-based cloning, and BuildKit SSH forwarding during image builds. Eval containers receive SSH keys via copy_to_container with GIT_SSH_COMMAND override for git fetch operations. Key changes: - _is_repo_private() caches GitHub API visibility check - mirror_url returns SSH URL for private repos, HTTPS for public - create_mirror() preserves source repo visibility - _prepare_dockerfile() injects BuildKit SSH mount into Dockerfiles - _docker_ssh_arg conditionally passes --ssh default only when needed - _find_ssh_key() discovers keys from GITHUB_USER_SSH_KEY or ~/.ssh/ - Threading lock prevents race condition in parallel SSH key copying - All profile classes and JS/TS helpers use visibility-aware URLs Co-Authored-By: Muhammed Karamuk <mkaramuk@proton.me>
Co-Authored-By: Rb <rubenwolff@gmail.com>
abb767f to
72c51ca
Compare
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
This is so awesome, thank you so much for adding! Will take a more thorough review pass later today. |
for more information, see https://pre-commit.ci
…pport Use _source_read_url and _configure_ssh_env() instead of hardcoded HTTPS/SSH URLs so private repos are cloned correctly.
Cover _find_ssh_key, SSH container logic, default_npm_install_dockerfile, _is_repo_private error path, _configure_ssh_env, _prepare_dockerfile, _docker_ssh_arg, and fix broken mock_open in test_python_profile_build_image.
for more information, see https://pre-commit.ci
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caaa82939f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…sh_arg Co-Authored-By: Rb <rubenwolff@gmail.com>
for more information, see https://pre-commit.ci
… errors Co-Authored-By: Rb <rubenwolff@gmail.com>
for more information, see https://pre-commit.ci
|
Hey @AlienKevin, I have updated the approach that codex pointed out. |
|
@codex Fix the pre-commit.ci failures |
|
Codex couldn't complete this request. Try again later. |
|
Merged, thanks for your contributions! |
Add private repository support across the pipeline. The system now detects repo visibility via GitHub API and automatically switches between HTTPS (public) and SSH (private) URLs for cloning, mirror creation, Docker image builds, and evaluation containers.