Gadget4 compatibility. #77
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that halos can be load before particle exchange
- reduce total number of particles in snapshot_io rather than in particle_exchanger - set GroupLoadedFullParticle in individual io - bugfix in gadget4_io
add jiutian config
halo_virial.cpp just copied from hydro branch; not working yet
ParticleExchangerBufferSize
HBTConfig.ParticleExchangerBufferSize=1e7 now determines the buffer size for particle query and subhalo host query
controllable memory size during particle exchange
also set default buffersize to 1e6
fixed incorrect datatype of MassLimit (int->float) used for deciding major progenitors. Previous runs with particle mass below 5e8 solar mass could be affected, so that the centrals for very low mass subhalos could be incorrectly selected
to account for bugfix in decide centrals
We do not need to specify box size for GADGET-4 snapshots
Collaborator
Author
|
Seems to be working. I ran it on a zoom-in simulation and it gave sensible results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made with the aim of implementing GADGET4 compatibility in HBT-HERONS. This change is based on the following branch: https://github.com/Kambrian/HBTplus/tree/MPI-Hydro-G4, whose development was driven by @Kambrian.
I had to change a few extra things to make it work with the current HBT-HERONS codebase, and I am currently adding capabilities to automatically set units/softening a la swift. I am also making the code automatically handle single / multiple file outputs.
Testing is ongoing.