Open
Conversation
Member
|
Fair enough. On the other hand, I've just had a look and this function is not used internally in swiftsimio itself anywhere. It is used:
The purpose is just to get the rotation matrix that aligns a vector with one of the coordinate axes. For that there's already |
Collaborator
Author
|
Thanks. I just had someone yesterday coming to ask me why it wasn't working, so I don't think we should get rid of it since some people must be relying on it. |
kyleaoman
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotations had to be imported explicitly, which I don't think should be required.