Add heatmap from pre-analyzed moves#809
Open
kevinsung wants to merge 1 commit intoSabakiHQ:masterfrom
Open
Conversation
Member
|
I don't like the non-standard SGF properties. Is anyone else using these? 🤔 I did intend for the heat map to be a fleeting (temporary) board layer as opposed to persisted in the SGF file. But more people do full-game analysis beforehand and want to look at the results. Maybe sync with @pnprog. |
Author
|
Yeah, for better or worse, using non-standard SGF properties is the most straightforward way to support full-game analysis. I did reach out to @pnprog at #487 but he hasn't responded. I would also love to know if other tools use similar non-standard properties; I couldn't find any besides @pnprog's Go Review Partner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #487 .
This lets Sabaki recognize the non-standard SGF properties VISITS, WINRATE, and SCORELEAD in order to draw a heatmap even with no engine analysis session running. Values from a running engine analysis session would override the values from the SGF.
I assumed the following definitions for these properties, but I can change them:
The diff is deceptively large because I indented an existing block by an additional level.
I have written a script that uses KataGo to add these properties to an SGF file: https://github.com/kevinsung/katago-analyze-sgf.
Screenshot:
