Improve Hexalock detection slightly #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Dec 29, 2024
Improve code with sabre's code suggestion Co-authored-by: Matt Nadareski <[email protected]>
Contributor
Author
|
Added suggested fix. Sorry, I didn't know the section name checks were case sensitive. |
Contributor
Author
|
This gets an instance where it wasn't flagged in a UPX executable. Is it alright to check UPX1 section strings? I'll roll it back if it isn't, dunno if doing string checks on UPX executables has issues in any scenarios. |
Collaborator
If you found it in the section and it's consistent, then add it. Otherwise, omit it. |
Contributor
Author
|
Alright. It is consistent and does work, so there's no problem, then |
mnadareski
reviewed
Dec 29, 2024
mnadareski
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hexalock disc has mfint.dll in a different section of PE. This PR causes it to be detected where it wasn't before. Some of Morlit's discs also weren't detecting, likely for similar reasons, but I have still yet to get to those.