[WIP] Language support#898
Closed
Deterous wants to merge 33 commits intoSabreTools:masterfrom
Deterous:master
Closed
[WIP] Language support#898Deterous wants to merge 33 commits intoSabreTools:masterfrom Deterous:master
Deterous wants to merge 33 commits intoSabreTools:masterfrom
Deterous:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't seem to figure out what's wrong, @mnadareski hope you can see in the changes tab what my idea is for adding language support. Maybe you're able to figure out how to implement this idea (no need to dev on my test branch).
I also have an idea for adding a little drop down in the UI menu bar. It's not wired in, but the idea is that UI language option shouldn't be hidden away in Options window because that requires navigating to it (in English).
More info:
https://learn.microsoft.com/en-us/windows/apps/develop/platform/xaml/xaml-resource-dictionary
Implementation for changing UI languages (when wired into the ComboBox):