Add Deserializer for AppPkgHeader #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Dec 17, 2024
| // Deserialize the SFB | ||
| var sfb = data.ReadType<Models.PlayStation3.SFB>(); | ||
| if (sfb?.Magic == SFBMagic) | ||
| if (sfb?.Magic != SFBMagic) |
Contributor
There was a problem hiding this comment.
Once rebased, this is no longer needed.
mnadareski
reviewed
Dec 17, 2024
| var appPkgHeader = new Models.PlayStation4.AppPkgHeader(); | ||
|
|
||
| // Try to parse the header | ||
| var header = data.ReadType<Models.PlayStation4.AppPkgHeader>(); |
Contributor
There was a problem hiding this comment.
This won't do what you want. This will read, by default, using little-endian on the majority of platforms. Once rebased, you can look at SFO and SFB as examples of how to handle big-endian deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endianness of PS3/PS4 magic numbers either needs to be fixed in Models or Serialization.