Add extra validity checks for GCF #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Jul 12, 2025
|
|
||
| #region Directory Header | ||
|
|
||
| // Try to parse game cache directory header for validity |
Contributor
There was a problem hiding this comment.
Nit: Remove "for validity"
mnadareski
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false GCF detection on idtech 5 md5 binary model format SabreTools/BinaryObjectScanner#376 . Adds a few extra validity checks mentioned in HLLib, specifically
https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L104
https://github.com/Rupan/HLLib/blob/47de5d5fed1b4d8e160c20f50d0bf61999996161/HLLib/GCFFile.h#L109
which should avoid any other false positives from Enemy Territory's md5b files.