Temporary fix for solid archive detection until SharpCompress makes another release. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the release of SharpCompress that Serialization uses is missing the fix for single-block solid archive detection that was pushed a month or so afterwards adamhathcock/sharpcompress#924 . From my own observations, and the experiences of various MPF/BOS users, solid archives (especially solid 7Z archives) tend to only be one block, so this winds up being a pretty major issue, resulting in extraction more or less locking up anytime a 7z is encountered. I understand that this fix isn't the most elegant, but it doesn't actually waste that much time since it only needs to check for two file entries, and it will have a major positive impact on processing times, given the state of solid extraction without it is borderline unusable on large archives with many files.
This backports what I had done for the original commit SabreTools/BinaryObjectScanner@ecd99b1 in the pull where this was first found SabreTools/BinaryObjectScanner#375 .