Skip to content

Small fix to temp solid code just in case #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 1 commit into from
Sep 27, 2025
Merged

Small fix to temp solid code just in case #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion SabreTools.Serialization/Wrappers/RAR.Extraction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu
}
}

if (isSolid)
// Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their
// end, it's possible that a multi-block solid archive might have the second (or more files) file not
// solid? It doesn't hurt to check either way.
if (isSolid || rarFile.IsSolid)
return ExtractSolid(rarFile, outputDirectory, includeDebug);
else
return ExtractNonSolid(rarFile, outputDirectory, includeDebug);
Expand Down
5 changes: 4 additions & 1 deletion SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu
}
}

if (isSolid)
// Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their
// end, it's possible that a multi-block solid archive might have the second (or more files) file not
// solid? It doesn't hurt to check either way.
if (isSolid || sevenZip.IsSolid)
return ExtractSolid(sevenZip, outputDirectory, includeDebug);
else
return ExtractNonSolid(sevenZip, outputDirectory, includeDebug);
Expand Down