Add extraction for installshield executables. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Oct 23, 2025
SabreTools.Serialization/Models/InstallShieldExecutable/ExtractableFile.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Models/InstallShieldExecutable/ExtractableFile.cs
Show resolved
Hide resolved
|
|
||
| namespace SabreTools.Serialization.Readers | ||
| { | ||
| public class InstallShieldExecutableFile : BaseBinaryReader<ExtractableFile> |
Contributor
There was a problem hiding this comment.
Future note: This will likely be expanded to cover an entire overlay section and not a singular entry.
Contributor
Author
There was a problem hiding this comment.
Will I need to do that? I'd be fine with doing it if I understood how it would be expanded to cover that.
SabreTools.Serialization/Readers/InstallShieldExecutableFile.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
mnadareski
reviewed
Oct 23, 2025
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles extraction for installshield executables. I know from experience that this probably won't work with earlier installshield executables that have MSIs inside, and potentially some other kind, but those also might be a different format anyways. Either way, the format is pretty simple and the only potential issues I'm worried about is whether something succeeds in getting the start of its overlay parsed like an installshield exe file entry.