Skip to content

increase buffer size for isexe reading / writing based on deterous's … #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 2 commits into from
Oct 26, 2025
Merged

increase buffer size for isexe reading / writing based on deterous's … #28

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9386e
increase buffer size for isexe reading / writing based on deterous's …
HeroponRikiBestest Oct 26, 2025
da9583b
remove comment
HeroponRikiBestest Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public bool ExtractInstallShieldExecutable(string outputDirectory, bool includeD
if (overlayAddress < 0)
return false;

const int chunkSize = 64 * 1024;
const int chunkSize = 2048 * 1024; //Arbitrary buffer size
Copy link
Contributor

@mnadareski mnadareski Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comment

Copy link
Contributor Author

@HeroponRikiBestest HeroponRikiBestest Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I wanted to leave it there so I remember that there isn't a need for this specific size, but fair enough.

Copy link
Contributor Author

@HeroponRikiBestest HeroponRikiBestest Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

var reader = new Readers.InstallShieldExecutableFile();

lock (_dataSourceLock)
Expand Down