add custom size when capture invisible widget#77
Open
ankiimation wants to merge 1 commit intoSachinGanesh:masterfrom
Open
add custom size when capture invisible widget#77ankiimation wants to merge 1 commit intoSachinGanesh:masterfrom
ankiimation wants to merge 1 commit intoSachinGanesh:masterfrom
Conversation
| Size logicalSize = ui.window.physicalSize / ui.window.devicePixelRatio; | ||
| Size imageSize = ui.window.physicalSize; | ||
| final Size rootSize = customSize ?? ui.window.physicalSize; | ||
| Size logicalSize = rootSize / ui.window.devicePixelRatio; |
There was a problem hiding this comment.
for the use case of generating a consistent image of some document across phones, the logical size should be set to the customSize - have confirmed this through testing, otherwise only the generated bitmap size is consistent.
|
@aaronreulkhoo Any update? |
|
Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add custom size when capture invisible widget