Skip to content

PA-1842: Update s12 proto to add prefix support#180

Merged
bhargysh-sc merged 1 commit intomainfrom
upgrade-s12-proto-version
Jun 23, 2025
Merged

PA-1842: Update s12 proto to add prefix support#180
bhargysh-sc merged 1 commit intomainfrom
upgrade-s12-proto-version

Conversation

@bhargysh-sc
Copy link
Copy Markdown
Contributor

@bhargysh-sc bhargysh-sc commented Jun 22, 2025

Summary

Bump s12 proto to pull in new validator for string (prefix).

Problem description

As part of post-release of https://github.com/SafetyCulture/s12-proto/releases/tag/v1.37.0 following this doc

it crowd

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...
  • For breaking changes: I have confirmed that other repos are not affected, or I have planned a deployment sequence to address any impact.

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@bhargysh-sc bhargysh-sc requested a review from a team as a code owner June 22, 2025 23:24
@bhargysh-sc bhargysh-sc merged commit 3a4c225 into main Jun 23, 2025
10 checks passed
@bhargysh-sc bhargysh-sc deleted the upgrade-s12-proto-version branch June 23, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants