Upgrade base protoc and protoc-cpp images to Alpine 3.21#184
Open
Paul De Audney (pdeaudney) wants to merge 2 commits intomainfrom
Open
Upgrade base protoc and protoc-cpp images to Alpine 3.21#184Paul De Audney (pdeaudney) wants to merge 2 commits intomainfrom
Paul De Audney (pdeaudney) wants to merge 2 commits intomainfrom
Conversation
- protoc base image: Alpine 3.15 -> 3.21, buf 1.8.0 -> 1.66.0 - protoc 3.18.1 -> 24.4, grpc 1.62.1 (from community repo) - protoc-cpp image: base protoc 1.14.2 -> 1.15.0 - Add abseil-cpp-dev and pkgconf build deps (required by protobuf v22+) - Regenerate wire_options.pb.cc/h during build to match container protobuf - Bump version to 1.13.0 - Fix legacy ENV format warning in Dockerfile Note: CRUX_CLIENT_RELEASE needs updating to a new s12-proto tag that includes the protobuf v24 string_view compatibility changes (see SafetyCulture/s12-proto PR upgrade/protobuf-v33-compatibility). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Harry Tran (HarryTranAU)
previously approved these changes
Mar 2, 2026
David Bailey (db112358)
previously approved these changes
Mar 2, 2026
protoc-cpp/Dockerfile
Outdated
|
|
||
| ENV CRUX_CLIENT_RELEASE 1.36.0 | ||
| # TODO: Update to new s12-proto release tag with protobuf v24 compatibility | ||
| ENV CRUX_CLIENT_RELEASE=1.36.0 |
Contributor
There was a problem hiding this comment.
Good to go once this is updated 🙌
Michael Gunawan (scmichaelg)
dismissed stale reviews from David Bailey (db112358) and Harry Tran (HarryTranAU)
via
aab243f
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocimage from Alpine 3.15 (EOL) to 3.21, bringing protobuf 3.18 -> 24.4 and grpc 1.62.1buffrom 1.8.0 to 1.66.0protoc-cppbuild to addabseil-cpp-devandpkgconfdependencies (required by protobuf v22+)wire_options.pb.cc/hduring Docker build to match container's protobuf versionprotocimage version to 1.15.0,protoc-cppto 1.13.0Dependencies
CRUX_CLIENT_RELEASEinprotoc-cpp/Dockerfileneeds updating to the new s12-proto release tag before mergingMerge order
v1.37.0)CRUX_CLIENT_RELEASEin this PR to match the new tagmake protoc && make cppPROTOC_CPP_VERSION=1.13.0in APISchema/MakefileOther affected images
protoc-nodeandprotoc-webalso referenceprotoc:1.14.2and will need separate updates toprotoc:1.15.0Test plan
protoc:1.15.0image builds successfullyprotoc-cpp:1.13.0image builds successfully (tested against s12-proto branch)make cruxin APISchema with newprotoc-cpp:1.13.0image🤖 Generated with Claude Code