feat(explorers): add support for environment in Sentry (AG-2031)#3943
Draft
sagely1 wants to merge 8 commits intoSage-Bionetworks:mainfrom
Draft
feat(explorers): add support for environment in Sentry (AG-2031)#3943sagely1 wants to merge 8 commits intoSage-Bionetworks:mainfrom
sagely1 wants to merge 8 commits intoSage-Bionetworks:mainfrom
Conversation
sagely1
commented
Mar 18, 2026
| .openchallenges.toml | ||
|
|
||
| # Generated app config files (from templates via envsubst) | ||
| **/config/config.json |
Contributor
Author
There was a problem hiding this comment.
Adding config.json to .gitignore to follow best practices
sagely1
commented
Mar 18, 2026
Comment on lines
+17
to
+23
| "create-config-json": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "command": "node ../../../tools/create-config-json.js", | ||
| "cwd": "{projectRoot}" | ||
| } | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Adds support to generate a config.json with nx run agora-app:create-config-json now that config.json is being gitignored.
sagely1
changed the title
sagely1
changed the title
sagely1
force-pushed
the
sentry-environment
branch
from
92e6b41 to
54804d5
Compare
sagely1
force-pushed
the
sentry-environment
branch
from
54804d5 to
075e865
Compare
sagely1
requested a deployment
to
model-ad-pr
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes hardcoded Sentry DSNs and moved them to runtime config (
config.json.templatevia${SENTRY_DSN}). The initial effort gathered valuable information about environments currently used in production. Going forward, the hostname to environment mapping can be removed in favor of being integrated into the deployment pipeline.Related Issue
AG-2031
Changelog
environmentis now injected at runtime via${SENTRY_ENVIRONMENT}instead of being derived fromwindow.location.hostnameinitSentrymethod - the interface now acceptsdsn,environment, andreleasecreate-config-jsonNx target andtools/create-config-json.jsscript to generateconfig.jsonfrom templates with${VAR:-default}syntax, replacing the committedconfig.jsonfiles (now gitignored)