Skip to content

Commit e573412

Browse files
committed
Clarify integration test
1 parent bd25790 commit e573412

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/integration/synapseclient/models/async/test_permissions_async.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,8 @@ async def test_entity_view_permissions(self, project_model: Project) -> None:
528528
"UPDATE",
529529
"CHANGE_SETTINGS",
530530
"CHANGE_PERMISSIONS",
531+
"DELETE",
532+
"MODERATE",
531533
]
532534
await entity_view.set_permissions_async(
533535
principal_id=user.id,
@@ -548,7 +550,7 @@ async def test_entity_view_permissions(self, project_model: Project) -> None:
548550
# Verify user permissions include both direct and inherited permissions
549551
user_acl = await entity_view.get_acl_async(principal_id=user.id)
550552
expected_user_permissions = set(
551-
limited_user_permissions + ["DOWNLOAD", "MODERATE"]
553+
limited_user_permissions + ["DOWNLOAD"]
552554
) # Includes auth users perm
553555
assert expected_user_permissions == set(user_acl)
554556

@@ -572,7 +574,7 @@ async def test_entity_view_permissions(self, project_model: Project) -> None:
572574

573575
# AND user permissions should no longer include DOWNLOAD
574576
user_acl_after = await entity_view.get_acl_async(principal_id=user.id)
575-
assert set(limited_user_permissions + ["MODERATE"]) == set(user_acl_after)
577+
assert set(limited_user_permissions) == set(user_acl_after)
576578

577579
# BUT team permissions should remain
578580
team_acl_after = await entity_view.get_acl_async(principal_id=team.id)

tests/integration/synapseclient/models/synchronous/test_permissions.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,6 +527,8 @@ async def test_entity_view_permissions(self, project_model: Project) -> None:
527527
"UPDATE",
528528
"CHANGE_SETTINGS",
529529
"CHANGE_PERMISSIONS",
530+
"DELETE",
531+
"MODERATE",
530532
]
531533
entity_view.set_permissions(
532534
principal_id=user.id,
@@ -547,7 +549,7 @@ async def test_entity_view_permissions(self, project_model: Project) -> None:
547549
# Verify user permissions include both direct and inherited permissions
548550
user_acl = entity_view.get_acl(principal_id=user.id)
549551
expected_user_permissions = set(
550-
limited_user_permissions + ["DOWNLOAD", "MODERATE"]
552+
limited_user_permissions + ["DOWNLOAD"]
551553
) # Includes auth users perm
552554
assert expected_user_permissions == set(user_acl)
553555

0 commit comments

Comments
 (0)